Closed (won't fix)
Project:
Panels
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
2 Jan 2008 at 20:13 UTC
Updated:
3 Nov 2009 at 16:10 UTC
Jump to comment: Most recent file
As per merlin's request in IRC, I've made some form items conditional, which results in a cleaner UI.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | panels_views_ui_10.patch | 7.76 KB | pancho |
| #5 | panels_views_ui.patch | 7.14 KB | wim leers |
| #3 | panels_views_ui.patch | 7.14 KB | wim leers |
| #3 | panels_views.js_.txt | 3.49 KB | wim leers |
| panels_views_ui.patch | 11.69 KB | wim leers |
Comments
Comment #1
merlinofchaos commentedTo really work, these need to be javascript conditionals that hide/reveal the items when the select box changes.
Comment #2
wim leersHeh! I agree, but I thought you wanted it this way, since Views works in a similar way. No problem.
Comment #3
wim leersI couldn't get the darn CVS fakeadd working and I want to go to bed, so that's a separate attachment. Put it in the panels_views directory.
Comment #4
merlinofchaos commentedAlas, now that I've applied your coding style patches, this no longer applies. I bet a cvs up will work better for you.
Comment #5
wim leersReroll. Don't forget to add the .js file from the previous attachments.
Comment #6
merlinofchaos commentedHmm. The new patch fails identically to the original; did you post the wrong one?
Comment #7
wim leersArgh. And I just cleaned up my pc today, so I don't have the new patch anymore :( Will have to reroll again then.
Comment #8
merlinofchaos commentedThis issue should not die.
Also, let's take dependency.js from Views 2 if we can make it work with an older jquery and older FAPI. That'll give us a lot more flexibility in doing stuff like this. We have LOTS of areas where we need form items to turn on or off depending on checkbox/select box state.
Raising the priority, too; this is important, IMO.
Comment #9
panchoThis is great stuff, and yes, we should extend this to many other forms we currently use, especially the menu generation (on the "Advanced" tab) comes into my mind.
Good that you raised the priority as this will impose string changes that need to be done before RC.
What I'm not so sure about are the first three hunks, where "view pane" is reverted to "panel view". Discussing the terminology led us to the point that we want to rename "panel view" to "view pane" as the former is misleading and the latter is also more correct. True, that we are not yet consistent and can't be before Panels3, but in the meanwhile we should do the conversion everywhere we don't break the API.
I'll take a closer look at this tomorrow afternoon.
Comment #10
panchoDidn't apply anymore, so I fiddled it together. This is a complete patch, it is broken, though.
Comment #11
sdboyer commentedOK, let's make this a goal for RC.
Comment #12
panchoUsing dependent.js from Views2 definitely seems to be the best way. I took a close look at it, but still don't feel comfortable enough with it to port it myself. Don't we need form.inc as well? This is gonna be a lot of work I guess.
Maybe for D5 we should consider using an interim solution like the one by Wim?
Comment #13
sdboyer commentedI really would like to see this in RC, but the patch is now pretty out of date. Any way you still have this, Wim, and might be able to re-roll it for us?
Thanks!
Comment #14
wim leersThe Drupal 5 version of this module is no longer maintained.